[App Service] az webapp deployment github-actions remove: Fix the bug that path cannot start with a slash - #21392
Merged
Conversation
calvinsID
requested review from
jsntcy,
panchagnula and
zhoxing-ms
as code owners
February 22, 2022 20:30
Collaborator
|
appservice |
wangzelin007
changed the title
wangzelin007
approved these changes
Feb 24, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wangzelin007
changed the title
az webapp deployment github-actions remove bug.
zhoxing-ms
approved these changes
Feb 24, 2022
zhoxing-ms
changed the title
az webapp deployment github-actions remove bug.az webapp deployment github-actions remove: Fix the bug that path cannot start with a slash
Contributor
|
@calvinsID were there no tests to re-record or add here? Please ensure in the future to add or re-record tests (in live mode) related to changes, Thanks! |
panchagnula
reviewed
Feb 24, 2022
Contributor
Author
There weren't any tests around the github actions commands, mainly due to the commands requiring a github personal access token and access to a github repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue in #20808 was already fixed (
az webapp deployment github-actions addcommand) but the same bug in theremovecommand wasn't fixedThis PR makes the same change in the
removecommandTesting Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.